Merged
Conversation
breedx-splk
force-pushed
the
add_opamp_attributes
branch
from
3a1edae to
f6b184b
Compare
robsunday
reviewed
Mar 9, 2026
custom/src/main/java/com/splunk/opentelemetry/opamp/OpampActivator.java
Outdated
Show resolved
Hide resolved
breedx-splk
force-pushed
the
add_opamp_attributes
branch
2 times, most recently
from
793b270 to
25b5a85
Compare
robsunday
reviewed
Mar 13, 2026
| assertIdentifyingString(agentToServer, SERVICE_VERSION, "test-ver"); | ||
| assertIdentifyingString(agentToServer, SERVICE_NAMESPACE, "test-ns"); | ||
|
|
||
| assertThat(agentToServer.agent_description.identifying_attributes) |
Contributor
There was a problem hiding this comment.
If you extract it to List<KeyValue> attrs = agentToServer.agent_description.identifying_attributes then many assertions possibly become easier to read one-liners
custom/src/test/java/com/splunk/opentelemetry/opamp/OpampActivatorTest.java
Outdated
Show resolved
Hide resolved
robsunday
reviewed
Mar 13, 2026
custom/src/test/java/com/splunk/opentelemetry/opamp/OpampActivatorTest.java
Outdated
Show resolved
Hide resolved
robsunday
approved these changes
Mar 16, 2026
# Conflicts: # custom/src/main/java/com/splunk/opentelemetry/opamp/OpampActivator.java
breedx-splk
force-pushed
the
add_opamp_attributes
branch
from
4fa2e88 to
3e91a99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases after #2675.